[PATCH] D154609: [X86] Preserve volatile ATOMIC_LOAD_OR nodes

[Nabeel Omer via Phabricator via llvm-commits]

n-omer updated this revision to Diff 537708.
n-omer added a comment.

Add test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154609/new/

https://reviews.llvm.org/D154609

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp


Index: llvm/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -33550,7 +33550,9 @@
   // changing, all we need is a lowering for the *ordering* impacts of the
   // atomicrmw.  As such, we can chose a different operation and memory
   // location to minimize impact on other code.
-  if (Opc == ISD::ATOMIC_LOAD_OR && isNullConstant(RHS)) {
+  // The above holds unless the node is marked volatile in which
+  // case it needs to be preserved according to the langref.
+  if (Opc == ISD::ATOMIC_LOAD_OR && isNullConstant(RHS) && !AN->isVolatile()) {
     // On X86, the only ordering which actually requires an instruction is
     // seq_cst which isn't SingleThread, everything just needs to be preserved
     // during codegen and then dropped. Note that we expect (but don't assume),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154609.537708.patch
Type: text/x-patch
Size: 931 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230706/a4ab365b/attachment.bin>