[PATCH] D154533: [DAG] Improve carry reconstruction in combineCarryDiamond.

Amaury SECHET via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 6 05:36:41 PDT 2023


deadalnix planned changes to this revision.
deadalnix added a comment.

In D154533#4476409 <https://reviews.llvm.org/D154533#4476409>, @uweigand wrote:

> Hi @deadalnix , it looks to me the test case exposes an actual bug.   A simplified test would be this:
> ...

Good catch. The carry reconstruction is a bit too optimistic. I'll rework this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154533/new/

https://reviews.llvm.org/D154533



More information about the llvm-commits mailing list