[PATCH] D154598: [CodeGen] Fix incorrectly detected reduction bug in ComplexDeinterleaving pass

Thu Jul 6 05:28:53 PDT 2023

mgabka added a comment.

Could you improve commit message description as well?

================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-reductions.ll:241
+; The reduced bug from D153355. Shows that reduction was detected where it did not exist.
+define void @bug(i1 %exitcond.not) #0 {
+; CHECK-LABEL: bug:
----------------
there is no attribute like that, I guess it can be removed, or if attribute was relevant for this test it needs to be added

================
Comment at: llvm/test/CodeGen/AArch64/complex-deinterleaving-reductions.ll:241
+; The reduced bug from D153355. Shows that reduction was detected where it did not exist.
+define void @bug(i1 %exitcond.not) #0 {
+; CHECK-LABEL: bug:
----------------
mgabka wrote:
> there is no attribute like that, I guess it can be removed, or if attribute was relevant for this test it needs to be added
I have a general comment about this test, to me looks like it can be simplified and do not use the aarch64 specific intrinsics,  isn't it the case that we have only fadd here but no load/store instructions?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154598/new/

https://reviews.llvm.org/D154598