[PATCH] D107087: Fix SectionMemoryManager deconstruction error with MSVC

Thu Jul 6 01:09:33 PDT 2023

sgraenitz added a comment.

In D107087#4473634 <https://reviews.llvm.org/D107087#4473634>, @v.g.vassilev wrote:

> @sgraenitz, could we move forward with the patch as is?

Well, it cannot land be cause it breaks the interface of `SectionMemoryManager`. If that gets fixed and the patch gets rebased, sure I will withdraw my veto.

> It fixes a whole bunch of issues for us.

In terms of the original issue, however, my fix should cover everything from this patch. And given that there has been no progress in this review for 2 years, I am not sure this will move forward anymore. I guess it's the `std::shared_ptr<MemoryMapper>` that your are referring to? That's not a bug fix but rather a feature. I guess you can implement it independent from this review.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107087/new/

https://reviews.llvm.org/D107087