[PATCH] D123804: [WIP][clang][lld] A Unified LTO Bitcode Frontend

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 23:25:55 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/test/Driver/unified-whole-program-vtables.c:1
+// RUN: %clang -target x86_64-pc-linux-gnu -fwhole-program-vtables -funified-lto -### %s 2>&1 | FileCheck %s
+// RUN: %clang -target x86_64-pc-linux-gnu -fwhole-program-vtables -fno-unified-lto -### %s 2>&1 | FileCheck %s
----------------
I think it'll be more readable if you place all -funitied-lto related driver tests in one file, instead of spreading them into unified-whole-program-vtables.c and lto-unit.c

Use `--target=` for new tests. `-target ` has been deprecated since Clang 3.4


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123804/new/

https://reviews.llvm.org/D123804



More information about the llvm-commits mailing list