[PATCH] D154198: [JITLink][PowerPC] Add TOC and relocations for ppc64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 21:09:18 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_ppc64.cpp:271
+  Error defineTOCBase(LinkGraph &G) {
+    for (Symbol *Sym : G.defined_symbols())
+      if (LLVM_UNLIKELY(Sym->getName() == ELFTOCSymbolName)) {
----------------
we add braces if the body is a complex statement.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_ppc64.cpp:280
+
+    for (Symbol *Sym : G.external_symbols())
+      if (Sym->getName() == ELFTOCSymbolName) {
----------------
we add braces if the body is a complex statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154198/new/

https://reviews.llvm.org/D154198



More information about the llvm-commits mailing list