[PATCH] D149773: [AMDGPU][IGLP] Add iglp_opt(1) strategy for single wave gemms

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added inline comments.
Herald added a subscriber: wangpc.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:92
+
+typedef std::pair<InstructionClassifier, SmallVector<SUnit *, 4>>
     InstructionRuleType;
----------------
Can you make this into a class or struct? We may want to add more to the Rule class than just the classifier and a cache.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:119
+  // The caches which each rule may use to store relevant SUnits
+  SmallVector<SmallVector<SUnit *, 4>, 4> Caches;
+
----------------
Unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149773/new/

https://reviews.llvm.org/D149773