[PATCH] D154544: [BOLT][DWARF] Fix for .debug_line with DWARF5
Maksim Panchenko via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 18:11:49 PDT 2023
maksfb accepted this revision.
maksfb added a comment.
This revision is now accepted and ready to land.
LGTM with a couple of nits addressed.
================
Comment at: bolt/lib/Core/DebugData.cpp:1669
while (StrData.isValidOffset(Offset)) {
+ uint64_t StrOffset = Offset;
Error Err = Error::success();
----------------
nit:
================
Comment at: bolt/lib/Core/DebugData.cpp:1676
}
- LineStr.emitRef(&Streamer, CStr);
+ size_t NewOffset = LineStr.addString(CStr);
+ assert(StrOffset == NewOffset &&
----------------
nit:
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154544/new/
https://reviews.llvm.org/D154544
More information about the llvm-commits
mailing list