[PATCH] D154555: DAG: Implement soften float for ffrexp

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 17:58:52 PDT 2023


arsenm added a comment.

In D154555#4475661 <https://reviews.llvm.org/D154555#4475661>, @alexfh wrote:

> Thanks for the quick fix! However, I'm not convinced this is a trivial fix for https://github.com/llvm/llvm-project/issues/63661, thus it may introduce other problems and make reverting to a known good state even more complex. As I mentioned on https://reviews.llvm.org/rG003b58f65bdd5d9c7d0c1b355566c9ef430c0e7d#1223579, I'd prefer a revert to green before this fix gets tested and the commits starting  from 003b58f65bdd5d9c7d0c1b355566c9ef430c0e7d <https://reviews.llvm.org/rG003b58f65bdd5d9c7d0c1b355566c9ef430c0e7d> are recommitted.

This is a trivial patch extending new functionality to just another case. The revert will be highly disruptive to my downstream uses that already exist and I will not be doing it. There is absolutely no reason to revert 003b58f65bdd5d9c7d0c1b355566c9ef430c0e7d <https://reviews.llvm.org/rG003b58f65bdd5d9c7d0c1b355566c9ef430c0e7d>. You could make an argument for reverting b15bf305ca3e9ce63aaef7247d32fb3a75174531 <https://reviews.llvm.org/rGb15bf305ca3e9ce63aaef7247d32fb3a75174531>, but that's more trouble than it's worth given here is the patch


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154555/new/

https://reviews.llvm.org/D154555



More information about the llvm-commits mailing list