[PATCH] D153084: AMDGPU: Partially fix not respecting dynamic denormal mode

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 15:39:43 PDT 2023


rampitec added a comment.

In D153084#4475290 <https://reviews.llvm.org/D153084#4475290>, @arsenm wrote:

> In D153084#4475241 <https://reviews.llvm.org/D153084#4475241>, @rampitec wrote:
>
>> It should be possible to logically separate it into 2 patches then: one reversing the flag but not changing the behavior, and then the fix itself?
>
> Yes, but it's kind of the same thing. I'd have to go spend the time to re-invert all the logic here and doesn't seem worth the effort

Most of the patch is the logic inversion, I believe I have scanned it 3 times already. Could you please highlight the actual fix, or why does the inversion itself fixes it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153084/new/

https://reviews.llvm.org/D153084



More information about the llvm-commits mailing list