[PATCH] D154545: [llvm-rc] Allow detection by Meson

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 15:32:32 PDT 2023


mstorsjo added a comment.

In D154545#4475392 <https://reviews.llvm.org/D154545#4475392>, @MaskRay wrote:

> This reminds me of D31199 <https://reviews.llvm.org/D31199> (https://www.sigbus.info/software-compatibility-and-our-own-user-agent-problem).
>
>> Also, since we cannot update the existing configure scripts that are already generated and distributed as part of other programs, even if we improve autoconf, it would take many years until the problem would be resolved.
>
> I think the Meson situation is better since projects don't bundle Meson in their released tarballs... I hope that we file a bug on https://github.com/mesonbuild/meson/issues and fix https://github.com/mesonbuild/meson/blob/1.1.1/mesonbuild/modules/windows.py#L97-L109 instead.

That’s probably reasonable - but we probably should land the other bits of this patch anyway. If you look at our current printouts, e.g. the original state of `helpmsg.test`, there’s literally nothing there that says `llvm-rc` or even LLVM in any form. So to get a reasonable regex for Meson to match against, we’d first need to improve the printout so that Meson has something reasonable to match against.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154545/new/

https://reviews.llvm.org/D154545



More information about the llvm-commits mailing list