[PATCH] D154544: [BOLT][DWARF] Fix for .debug_line with DWARF5

Maksim Panchenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 15:20:27 PDT 2023


maksfb added inline comments.


================
Comment at: bolt/lib/Core/DebugData.cpp:1675
     }
-    LineStr.emitRef(&Streamer, CStr);
+    LineStr.addString(CStr);
   }
----------------
The returned offset has to match the input `Offset`, right? Add a check.


================
Comment at: llvm/include/llvm/MC/MCDwarf.h:74
+
+  /// Adds path to the line string
+  size_t addString(StringRef Path);
----------------
Add documentation for the return value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154544/new/

https://reviews.llvm.org/D154544



More information about the llvm-commits mailing list