[PATCH] D153084: AMDGPU: Partially fix not respecting dynamic denormal mode

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 14:39:56 PDT 2023


rampitec added a comment.

In D153084#4475195 <https://reviews.llvm.org/D153084#4475195>, @arsenm wrote:

> In D153084#4474883 <https://reviews.llvm.org/D153084#4474883>, @rampitec wrote:
>
>> Can you please explain why does it need reversal of the HasFP32Denormals? This creates a lot turmoil.
>
> It's conceptually backwards. The default logic has to be treat like IEEE. It needs to be the positive condition that we definitely have flushing on

It should be possible to logically separate it into 2 patches then: one reversing the flag but not changing the behavior, and then the fix itself?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153084/new/

https://reviews.llvm.org/D153084



More information about the llvm-commits mailing list