[PATCH] D152577: Part 2 of Fine tune MachineFunctionSplitPass (MFS) for FSAFDO.

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1280
+        // enabled, this may result in performance degradation.
+        report_fatal_error("Must use AutoFDO with FSDiscriminator for MFS.");
+      }
----------------
hoy wrote:
> A fatal error seems too strong to me. Can we do a warning instead so that we can still experiment with non-FS AutoFDO profile?
Agree. There is no correctness issue, and sub-optimal performance doesn't justify a fatal.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152577/new/

https://reviews.llvm.org/D152577