[PATCH] D154395: [llvm] Add triple for SerenityOS

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/include/llvm/TargetParser/Triple.h:681
 
+  /// Tests whether the OS is SerenityOS
+  bool isOSSerenity() const {
----------------
I know you follow some existing comments, but the code really speaks for itself. I think the commend should be removed.


================
Comment at: llvm/unittests/TargetParser/TripleTest.cpp:897
 
+  T = Triple("x86_64-pc-serenity");
+  EXPECT_EQ(Triple::x86_64, T.getArch());
----------------
Ensure that this is the triple SerenityOS prefers. I.e. you prefer x86_64-pc-serenity instead of x86_64-unknown-serenity


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154395/new/

https://reviews.llvm.org/D154395