[PATCH] D41766: [MachineCombiner] Add check for optimal pattern order.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

> I have a high-level question for this patch. I understand that the verify function aims to verify patterns to be present in certain order but insertion is not guaranteed to be in the same order.
>
> Does it make sense to have this verification in the first place?

The machine combiner applies the pattern in order, so the goal is to ensure that the most profitable patterns are processed first. Did you encounter cases where it wasn't possible to fix the insertion order?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D41766/new/

https://reviews.llvm.org/D41766