[PATCH] D147544: [BOLT] Move from RuntimeDyld to JITLink

Wed Jul 5 11:10:10 PDT 2023

rafauler added a comment.

In D147544#4473532 <https://reviews.llvm.org/D147544#4473532>, @treapster wrote:

> Hello, @jobnoorman, out team is currently evaluating possible improvements to LongJmp pass, and we're wondering what are the opportunities for doing relaxation/stub insertion on JITLink side? I see currently JITLink can build PLT with TableManager and relax some calls to it and GOT accesses, do you think it's possible/worth it to to extend this functionality further to support a more general replacement of instructions as we do in LongJMP? It seems it already works like that for RISCV because of D149526 <https://reviews.llvm.org/D149526>, does that mean we can implement similar patches for AArch64/x86 and throw LongJmp away? I guess it would be tricky for X86 because of all the encoding mess, but i'm wondering what your thoughts are.

I think I already asked this but remind me again, why is LongJmp being used for X86? Is this golang support? We shouldn't use longjmp for X86. This pass was written for AArch64 and RISC's short ranged branches.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147544/new/

https://reviews.llvm.org/D147544