[PATCH] D154526: [llvm-mca][RISCV] vsetivli and vsetvli act as instruments

Michael Maitland via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 10:14:26 PDT 2023


michaelmaitland created this revision.
michaelmaitland added reviewers: myhsu, craig.topper, reames, andreadb.
Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, gbedwell, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, hiraditya, arichardson.
Herald added a project: All.
michaelmaitland requested review of this revision.
Herald added subscribers: llvm-commits, wangpc, eopXD, MaskRay.
Herald added a project: LLVM.

Since the LMUL data that is needed to create an instrument is
avaliable statically from vsetivli and vsetvli instructions,
LMUL instruments can be automatically generated so that clients
of the tool do no need to manually insert instrument comments.

Instrument comments may be placed after a vset{i}vli instruction,
which will override instrument that was automatically inserted.
As a result, clients of llvm-mca instruments do not need to update
their existing instrument comments. However, if the instrument
has the same LMUL as the vset{i}vli, then it is reccomended to
remove the instrument comment as it becomes redundant.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154526

Files:
  llvm/include/llvm/MCA/CustomBehaviour.h
  llvm/lib/MCA/CustomBehaviour.cpp
  llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.cpp
  llvm/lib/Target/RISCV/MCA/RISCVCustomBehaviour.h
  llvm/test/tools/llvm-mca/RISCV/no-vsetvli-to-start.s
  llvm/test/tools/llvm-mca/RISCV/vsetivli-lmul-instrument.s
  llvm/test/tools/llvm-mca/RISCV/vsetvli-lmul-instrument.s
  llvm/tools/llvm-mca/CodeRegionGenerator.cpp
  llvm/tools/llvm-mca/CodeRegionGenerator.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154526.537412.patch
Type: text/x-patch
Size: 23462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230705/3c8d66e8/attachment-0001.bin>


More information about the llvm-commits mailing list