[PATCH] D154506: [ARM] in LowerConstantFP, make sure we cover armv6-m execute-only

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 07:51:02 PDT 2023


dmgreen added a comment.

I see. You are adding this for v6m, but v6m will never have legal FP types so will never get here?

We usually won't make changes like this if the code is already unreachable. Maybe turn them into a assert instead? In this case it looks fine though, presuming we don't want the combination of vfp2 and execute-only.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154506/new/

https://reviews.llvm.org/D154506



More information about the llvm-commits mailing list