[PATCH] D154504: [UTC] Fix git URL regex

[Henrik G Olsson via Phabricator via llvm-commits]

hnrklssn added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/common.py:1576
 METADATA_FILTERS = [
-    r"(\w+ version )[\d.]+ \(git@[\w.:/-]+\.git \w+\)",
+    r"(\w+ version )[\d.]+ \([\w.:/@-]+\.git \w+\)",
     r'(!DIFile\(filename: ".+", directory: )".+"',
----------------
hnrklssn wrote:
> nikic wrote:
> > I think this needs to be more permissive than that. E.g. my installed clang version is `clang version 15.0.7 (Fedora 15.0.7-2.fc37)` and my development version is just `clang version 17.0.0` because I have git detection disabled. (If this is the same as `clang -v`.)
> Do you think `(\w+ version )[\d.]+( \([\w.:/@ -]+\))?` would work well, or should we go all out with `(\w+ version )[\d.]+.*`?
Looking into the various possible custom version outputs, I think this is a reasonable approach that works well for all outputs that don't contain the `"` character: `(\w+ version )[\d.]+.*(?=\")`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154504/new/

https://reviews.llvm.org/D154504