[PATCH] D154504: [UTC] Fix git URL regex
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 5 05:42:46 PDT 2023
nikic added inline comments.
================
Comment at: llvm/utils/UpdateTestChecks/common.py:1576
METADATA_FILTERS = [
- r"(\w+ version )[\d.]+ \(git@[\w.:/-]+\.git \w+\)",
+ r"(\w+ version )[\d.]+ \([\w.:/@-]+\.git \w+\)",
r'(!DIFile\(filename: ".+", directory: )".+"',
----------------
I think this needs to be more permissive than that. E.g. my installed clang version is `clang version 15.0.7 (Fedora 15.0.7-2.fc37)` and my development version is just `clang version 17.0.0` because I have git detection disabled. (If this is the same as `clang -v`.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154504/new/
https://reviews.llvm.org/D154504
More information about the llvm-commits
mailing list