[PATCH] D154504: [UTC] Fix git URL regex

Henrik G Olsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 5 05:38:56 PDT 2023


hnrklssn created this revision.
hnrklssn added a reviewer: nikic.
Herald added subscribers: StephenFan, arichardson.
Herald added a project: All.
hnrklssn requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The previous git URL regex only matched SSH urls, starting with 'git@'.
If the repo was cloned using a https URL it would not match.

rdar://105239218


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D154504

Files:
  llvm/utils/UpdateTestChecks/common.py


Index: llvm/utils/UpdateTestChecks/common.py
===================================================================
--- llvm/utils/UpdateTestChecks/common.py
+++ llvm/utils/UpdateTestChecks/common.py
@@ -1573,7 +1573,7 @@
 
 # The capture group is kept as is, followed by a {{.*}} glob
 METADATA_FILTERS = [
-    r"(\w+ version )[\d.]+ \(git@[\w.:/-]+\.git \w+\)",
+    r"(\w+ version )[\d.]+ \([\w.:/@-]+\.git \w+\)",
     r'(!DIFile\(filename: ".+", directory: )".+"',
 ]
 METADATA_FILTERS_RE = [re.compile(s) for s in METADATA_FILTERS]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D154504.537317.patch
Type: text/x-patch
Size: 536 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230705/8d86ffd2/attachment.bin>


More information about the llvm-commits mailing list