[PATCH] D153758: [AMDGPU] Use GlobalISel MatchTable Combiner Backend

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh updated this revision to Diff 537265.
Pierre-vh added a comment.
Herald added a subscriber: ThomasRaoux.
Herald added a reviewer: zuban32.
Herald added a reviewer: mpaszkowski.

Add missing setupMF call

Currently it's called on every call to combine() which is annoying. I'd prefer if we only instantiated everything once.
It's a cheap function though so I believe it's fine to start with.

I think when/if this all lands and the dust settles a bit, we need to remove CombinerInfo and replace it with something
closer to InstructionSelector, e.g. have a InstructionCombiner base class and instantiate it once.
It's a bigger refactor though so I think it's better to do it later to make the review stack less confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153758/new/

https://reviews.llvm.org/D153758

Files:
  llvm/include/llvm/CodeGen/GlobalISel/GIMatchTableExecutor.h
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCombine.td
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
  llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp
  llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp
  llvm/lib/Target/AMDGPU/AMDGPURegBankCombiner.cpp
  llvm/lib/Target/AMDGPU/CMakeLists.txt
  llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D153758.537265.patch
Type: text/x-patch
Size: 53414 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230705/f4ac382d/attachment.bin>