[PATCH] D149439: [yaml2obj] Add support fot structured section data.

Wed Jul 5 02:07:30 PDT 2023

jhenderson accepted this revision.
jhenderson added a comment.

LGTM.

I'm happy to support any other extensions to this that prove useful. COFF yaml2obj is in need of a lot of love compared to the flexibility of ELF yaml2obj, so any improvements would be gratefully received.

================
Comment at: llvm/lib/ObjectYAML/COFFYAML.cpp:604
   // is carried in SizeOfRawData, even though PointerToRawData is zero.
-  if (Sec.SectionData.binary_size() == 0 &&
+  if (Sec.SectionData.binary_size() == 0 && Sec.StructuredData.empty() &&
       NC->Characteristics & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)
----------------
jhenderson wrote:
> Test case that shows this bit of code has changed (correctly)?
Tip, clicking the checkbox to mark a comment as "Done", prior to uploading the updated patch makes it easier to see if a comment has been addressed.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149439/new/

https://reviews.llvm.org/D149439