[PATCH] D151312: [PowerPC][AIX] Enable quadword atomics by default for AIX

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/docs/ReleaseNotes.rst:204
+  atomics on AIX. Now backend generates lock-free quadword atomics code on AIX
+  by default. To support lock-free quadword atomics in libatomic, the os level
+  must be at least AIX 7.2 TL5 SP3 with libc++.rte of version 17.1.1 or above
----------------
Minor nit: s/os/OS;


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:18439-18440
 bool PPCTargetLowering::shouldInlineQuadwordAtomics() const {
-  // TODO: 16-byte atomic type support for AIX is in progress; we should be able
-  // to inline 16-byte atomic ops on AIX too in the future.
-  return Subtarget.isPPC64() &&
-         (EnableQuadwordAtomics || !Subtarget.getTargetTriple().isOSAIX()) &&
-         Subtarget.hasQuadwordAtomics();
+  // The ability to turn off quadword atomics for AIX is a historical artifact,
+  // i.e., for transition of libatomic on AIX.
+  return Subtarget.isPPC64() && Subtarget.hasQuadwordAtomics();
----------------
Comment can now be removed entirely. It speaks to code that is no longer present.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151312/new/

https://reviews.llvm.org/D151312