[PATCH] D154280: [LIT] Added an option to llvm-lit to emit the necessary test coverage data, divided per test case

[Dan Liew via Phabricator via llvm-commits]

delcypher added inline comments.


================
Comment at: llvm/docs/CMake.rst:378
 
+**LLVM_TEST_COVERAGE**:BOOL
+  Enable individual test case coverage. When set to ON, code coverage data
----------------
This documentation seems inaccurate right now. Reading the implementation, enabling this option doesn't actually cause any coverage to be collected. I suspect you will do this in later patches but I would suggest you update the documentation when the feature actually works.

Nits:

* `LLVM_TEST_COVERAGE` is a vague name. `LLVM_INDIVIDUAL_TEST_COVERAGE` might be more specific.
* Consider being more specific about where the code coverage data is written (e.g. under the `config.test_exec_root` directory.
* Documentation doesn't typically use the phrase "This allows you to...". Instead consider writing " This allows code coverage analysis of each individual test case"

Super nit:

* Missing fullstop (period) at the end of the last sentence.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154280/new/

https://reviews.llvm.org/D154280