[PATCH] D154430: [FileCheck, 4/4] NFC: Stop using ExpressionValue

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:81
 Expected<std::string>
-ExpressionFormat::getMatchingString(ExpressionValue IntegerValue) const {
-  APInt IntValue = IntegerValue.getAPIntValue();
-  if (Value != Kind::Signed && IntValue.isNegative())
+ExpressionFormat::getMatchingString(APInt IntegerValue) const {
+  if (Value != Kind::Signed && IntegerValue.isNegative())
----------------
arichardson wrote:
> Could also rename the argument here instead of updating all users?
Sure, I was trying to keep naming consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154430/new/

https://reviews.llvm.org/D154430