[PATCH] D154101: [MC] Add three-state parseDirective as a replacement for ParseDirective
Sergei Barannikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 4 14:03:46 PDT 2023
barannikov88 marked an inline comment as done.
barannikov88 added inline comments.
================
Comment at: llvm/lib/Target/BPF/AsmParser/BPFAsmParser.cpp:520
+ParseStatus BPFAsmParser::parseDirective(AsmToken DirectiveID) {
+ return ParseStatus::NoMatch;
+}
----------------
barannikov88 wrote:
> kosarev wrote:
> > Can we just remove this function? +Same for LoongArch, M68k, Xtensa.
> I guess we can. The old method was pure virtual and had to be overridden, the new one does not have to.
>
fda24e86
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154101/new/
https://reviews.llvm.org/D154101
More information about the llvm-commits
mailing list