[PATCH] D153698: [InstCombine] canonicalize multi xor as cmp+select

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4285
+    // Avoid some regression case.
+    if (isa<SelectInst>(I) || isa<CmpInst>(I) || isa<LoadInst>(I))
+      return V;
----------------
Could you explain a bit more about why this is necessary for avoiding a regression?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153698/new/

https://reviews.llvm.org/D153698