[PATCH] D154430: [FileCheck, 4/4] NFC: Stop using ExpressionValue
Alexander Richardson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 4 09:19:36 PDT 2023
arichardson accepted this revision.
arichardson added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:81
Expected<std::string>
-ExpressionFormat::getMatchingString(ExpressionValue IntegerValue) const {
- APInt IntValue = IntegerValue.getAPIntValue();
- if (Value != Kind::Signed && IntValue.isNegative())
+ExpressionFormat::getMatchingString(APInt IntegerValue) const {
+ if (Value != Kind::Signed && IntegerValue.isNegative())
----------------
Could also rename the argument here instead of updating all users?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154430/new/
https://reviews.llvm.org/D154430
More information about the llvm-commits
mailing list