[PATCH] D153544: [AMDGPU] Use V_FMA_MIX* more often
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 4 09:18:28 PDT 2023
foad added inline comments.
================
Comment at: llvm/lib/Target/AMDGPU/VOP3PInstructions.td:187
+ (f32 (VOP3PMadMixMods f32:$src1, i32:$src1_modifiers))))),
+ (mixlo_inst $src0_modifiers, $src0,
+ $src1_modifiers, $src1,
----------------
arsenm wrote:
> If this is using v_mad_mix (i.e >= gfx900 && < gfx906), you can't introduce v_mad* without checking if denormal flushing is enabled
Is that a pre-existing problem with the other patterns in this multiclass (I see there is a TODO comment about it at the top)? Or do they check for denormal handling before creating anything that matches `fma_like`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153544/new/
https://reviews.llvm.org/D153544
More information about the llvm-commits
mailing list