[PATCH] D154369: [PowerPC] Add DFP quantum adjustment instruction definitions and MC tests

Stefan Pintilie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 09:13:38 PDT 2023


stefanp added a comment.

I think this mostly looks good all I found was a couple of typos in two instructions.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:183
+                                (ins f8rc:$FRA, f8rc:$FRB, u2imm:$RMC),
+                                "drmd", "$FRT, $FRA, $FRB, $RMC", []>;
+defm DRMDQ: Z23Form_FRTAB5_RMC2r<63, 35, (outs fpairrc:$FRT),
----------------
Typo:
I think that this instruction is `drrnd`. 


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrDFP.td:186
+                                 (ins fpairrc:$FRA, fpairrc:$FRB, u2imm:$RMC),
+                                 "drmdq", "$FRT, $FRA, $FRB, $RMC", []>;
+defm DRINTX: Z23Form_FRTB5_R1_RMC2r<59, 99, (outs f8rc:$FRT),
----------------
Typo:
This one too. I think it is `drrndq`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154369/new/

https://reviews.llvm.org/D154369



More information about the llvm-commits mailing list