[PATCH] D154348: Ignore modified attribute list if it yields invalid IR

Manish Kausik H via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 07:47:49 PDT 2023


Nirhar added inline comments.


================
Comment at: llvm/tools/bugpoint/CrashDebugger.cpp:374
+  Passes.push_back("verify");
+  std::unique_ptr<Module> New = BD.runPassesOn(M.get(), Passes);
+  if (!New)
----------------
lattner wrote:
> Can you use `llvm::verifyModule` instead of running the pass?
Other parts of the `CrashDebugger` run the pass to verify llvm IR, hence I kept it the same. Let me know if I should still change to `llvm::verifyModule`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154348/new/

https://reviews.llvm.org/D154348



More information about the llvm-commits mailing list