[PATCH] D154341: use StringMap in llvm-dwp when merging debug_str.dwo section

zhuna via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 06:51:37 PDT 2023


zhuna8616 added a comment.

My bad... I forgot to convert `const char *` to `StringRef`.

StringRef alone doesn't seem to do any copy. StringMap copies the key into the map. The old implementation uses `const char *` and has none of such problem. I can think of no other way to it if we persist using StringMap.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154341/new/

https://reviews.llvm.org/D154341



More information about the llvm-commits mailing list