[PATCH] D152281: [Transforms][LICM] Add the ability to undo unprofitable reassociation

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 06:42:23 PDT 2023


qcolombet added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:2677
 
+static bool hoistFPAssociation(Instruction &I, Loop &L,
+                               ICFLoopSafetyInfo &SafetyInfo,
----------------
Could you add a comment on what this function is doing and what it means to return true or false?

It'll make the review easier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152281/new/

https://reviews.llvm.org/D152281



More information about the llvm-commits mailing list