[PATCH] D154438: [AMDGPU] Fix incorrect hazard mitigation

Stephen Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 06:11:10 PDT 2023


stepthomas added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/vcmpx-exec-war-hazard.mir:149
 
 # GCN-LABEL: name: hazard_vcmpx_smov_exec_lo_depctr_effe
 # GCN:        $sgpr0 = S_MOV_B32 $exec_lo
----------------
foad wrote:
> If you're renaming tests, maybe change this one to `no_hazard_`?
I did consider this, but decided that the test was illustrating a case where the was a hazard, it's just that the hazard recognizer had now correctly identified that it was already mitigated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154438/new/

https://reviews.llvm.org/D154438



More information about the llvm-commits mailing list