[PATCH] D150880: [RFC, FileCheck] Allow AP value for numeric expressions

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 04:04:50 PDT 2023


thopre marked 4 inline comments as done.
thopre added inline comments.


================
Comment at: llvm/unittests/FileCheck/FileCheckTest.cpp:382-386
+template <class T> static APInt toAPInt(T Value) {
+  if (std::is_unsigned_v<T>)
+    return APInt(128, Value);
+  return APInt(128, Value, /*IsSigned=*/true);
 }
----------------
Unused, oops


================
Comment at: llvm/unittests/FileCheck/FileCheckTest.cpp:474-478
+#if 0
+  expectOperationValueResult(exprSub, 10,
                              static_cast<uint64_t>(MaxInt64) + 11,
                              -MaxInt64 - 1);
+#endif
----------------
Oops


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150880/new/

https://reviews.llvm.org/D150880



More information about the llvm-commits mailing list