[PATCH] D152358: [CGP] Remove operand of llvm.assume more aggressively.

[Serguei Katkov via Phabricator via llvm-commits]

skatkov added a comment.

I've taken a look at CodeMetrics::collectEphemeralValues. It does not recognize loops with phi node as well. I can extend its detector, however it collects ephemeral values basing on conditions "I->mayHaveSideEffects() || I->isTerminator()".

It is less than RecursivelyDeleteTriviallyDeadInstructions which is used currently in CodeGenPrepare. For example, RDTDI can remove allocations...

So, let's decide in what direction should I move.

The idea to remove it earlier.... Not sure at what moment we should do it. It might be useful one if some one will use it properly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152358/new/

https://reviews.llvm.org/D152358