[PATCH] D153850: [AArch64] Use GlobalISel MatchTable Combiner Backend

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerCombiner.cpp:409
                                                MachineIRBuilder &B) const {
-  const auto *LI =
-      MI.getParent()->getParent()->getSubtarget().getLegalizerInfo();
+  const auto &STI = MI.getMF()->getSubtarget<AArch64Subtarget>();
+  const auto *LI = STI.getLegalizerInfo();
----------------
arsenm wrote:
> There's a subtarget member?
There is no subtarget member in `AArch64PostLegalizerCombinerInfo` or `MI` as far as I can see


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64PostLegalizerLowering.cpp:416
 
-static bool matchEXT(MachineInstr &MI, MachineRegisterInfo &MRI,
-                     ShuffleVectorPseudo &MatchInfo) {
+bool matchEXT(MachineInstr &MI, MachineRegisterInfo &MRI,
+              ShuffleVectorPseudo &MatchInfo) {
----------------
arsenm wrote:
> Why are these losing static?
They've been moved in an anonymous namespace and `static` is implied already in those


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153850/new/

https://reviews.llvm.org/D153850