[PATCH] D153757: [RFC][TableGen][GlobalISel] Add Combiner Match Table Backend

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 03:00:36 PDT 2023


Pierre-vh marked an inline comment as done.
Pierre-vh added inline comments.


================
Comment at: llvm/test/TableGen/GlobalISelCombinerMatchTableEmitter/match-table.td:75-78
+// CHECK-NEXT:   MachineFunction &MF = *I.getParent()->getParent();
+// CHECK-NEXT:   MachineRegisterInfo &MRI = MF.getRegInfo();
+// CHECK-NEXT:   const TargetSubtargetInfo &ST = MF.getSubtarget();
+// CHECK-NEXT:   const PredicateBitset AvailableFeatures = getAvailableFeatures();
----------------
arsenm wrote:
> I'd expect all of this boilerplate to be in member / per function state initialization in the combiner info 
MF/MRI maybe (see D153756), the others too?
Note ST is simply to shorten the code a bit, it's just used to fetch InstrInfo/RegBankInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153757/new/

https://reviews.llvm.org/D153757



More information about the llvm-commits mailing list