[PATCH] D151204: [VPlan] Allow sinking of instructions with no defs

[Evgeniy via Phabricator via llvm-commits]

ebrevnov added a comment.
Herald added a subscriber: wangpc.

Florian, thank you for review.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:668
+    if (SinkCandidate->mayHaveSideEffects())
+          return false;
+
----------------
fhahn wrote:
> nit: indentation seems off here, please make sure the patch is formatted properly before landing.
Fixed.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp:680
            "only recipes with a single defined value expected");
+    // Skip instruction if it doesn't define a new value (meaning there are no
+    // more users).
----------------
fhahn wrote:
> For now, I think with the fix above the original assert should be kept and handling for recipes with zero defined values should not be needed. If not, at least the assert will help to surface a test case.
Ok, restored assert back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151204/new/

https://reviews.llvm.org/D151204