[PATCH] D153758: [AMDGPU] Use GlobalISel MatchTable Combiner Backend

Pierre van Houtryve via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 02:50:56 PDT 2023


Pierre-vh marked an inline comment as done.
Pierre-vh added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:85
+  matchRcpSqrtToRsq(MachineInstr &MI,
+                    std::function<void(MachineIRBuilder &)> &MatchInfo) const;
 
----------------
arsenm wrote:
> function_ref(I guess this was wrong before)
It doesn't work because of the lifetime of the function unfortunately, there's a segfault


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153758/new/

https://reviews.llvm.org/D153758



More information about the llvm-commits mailing list