[PATCH] D154422: [AMDGPU] Add new BFI intrinsic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 02:43:56 PDT 2023


arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

We’ve specifically avoided adding intrinsics for easy to match instructions. This needs a semantic justification over just emitting the expanded bit sequence. It’s a huge amount of work teaching every part of the compiler the equivalent bit optimizations.



================
Comment at: llvm/test/CodeGen/AMDGPU/bfi_nested.ll:3
-; RUN: llc -march=amdgcn -verify-machineinstrs < %s | FileCheck -enable-var-scope -check-prefix=GCN %s
-
-define float @v_bfi_single_nesting_level(float %x, float %y, float %z) {
----------------
Why lose a test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154422/new/

https://reviews.llvm.org/D154422



More information about the llvm-commits mailing list