[PATCH] D154363: [WIP][mlir] Add an interface to decompose complex ops

[Renato Golin via Phabricator via llvm-commits]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM with a few comment nits.



================
Comment at: mlir/include/mlir/Interfaces/AggregatedOpInterface.td:32
+          to replace the results of the current operation.
+          Therefore, it must return one value per result.
+        }],
----------------
This comment seems at odds with the return type being a small vector of values.


================
Comment at: mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp:2412
+///
+/// 2. Subtract m from x and exponentiate. This results in
+///    a N dimensional tensor z.
----------------
Nit: "subtract a 'broadcasted' m from x" to make it clear that this is now an "element wise" subtraction on (dim=d), even if the op can just read the same element with a smart affine map.

The broadcast doesn't need to be an op, this would be just to make clear the semantics. (and even if it was, it could still be fused with the following op).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154363/new/

https://reviews.llvm.org/D154363