[PATCH] D143759: [AMDGPU] Implement whole wave register spill

[Yashwant Singh via Phabricator via llvm-commits]

yassingh added a subscriber: crobeck.
yassingh added inline comments.


================
Comment at: llvm/test/CodeGen/MIR/AMDGPU/long-branch-reg-all-sgpr-used.ll:42
 ; CHECK-NEXT:   vgprForAGPRCopy: ''
+; CHECK-NEXT:   sgprForEXECCopy: '$sgpr100_sgpr101'
 ; CHECK-NEXT:   longBranchReservedReg: ''
----------------
We are using sgpr100, sgpr101 in our code below using inline asm calls why not sure what do they mean here?
cc @cdevadas 


================
Comment at: llvm/test/CodeGen/MIR/AMDGPU/long-branch-reg-all-sgpr-used.ll:307
+; CHECK-NEXT:   sgprForEXECCopy: '$sgpr100_sgpr101'
+; CHECK-NEXT:   longBranchReservedReg: ''
 ; CHECK-NEXT: body:
----------------
@crobeck I believe this test is now not serving the purpose you added it for. I tried freeing up s98 and s99(see below changes in the same file) expecting them to be used for 'longBranchReservedReg', but didn't work.  Any pointers on why it might be? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143759/new/

https://reviews.llvm.org/D143759