[PATCH] D153544: [AMDGPU] Use V_FMA_MIX* more often

Mateja Marjanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 4 01:28:17 PDT 2023


matejam marked 4 inline comments as done.
matejam added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/mad-mix-lo.ll:2186
+}
+
 declare half @llvm.minnum.f16(half, half) #1
----------------
arsenm wrote:
> Need tests with source modifiers and multiple uses, plus the permutations with the lo and hi cases. Also denormal flushing on and off
> 
> Also need all the tests for the other pattern
Multiple uses meaning that I should have more instructions which use %mul?
Denormal flushing is covered in test/CodeGen/AMDGPU/GlobalISel/fdiv.f16.ll.
I will work on v_fma/mad_mixhi combing now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153544/new/

https://reviews.llvm.org/D153544



More information about the llvm-commits mailing list