[PATCH] D154193: [X86]Remove TEST in AND32ri+TEST16rr in peephole-opt

Wang, Xin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 22:07:29 PDT 2023


XinWang10 added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:1000
+    VregDefInstr = MRI->getVRegDef(CmpValDefInstr.getOperand(1).getReg());
+    if (!VregDefInstr)
+      return false;
----------------
skan wrote:
> Should this be an assert?
No, VregDefInstr could be nullptr if CmpValDefInstr is just a copy from reg, and not a copy sub16bit from an AND32ri.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154193/new/

https://reviews.llvm.org/D154193



More information about the llvm-commits mailing list