[PATCH] D154173: [LAA] Add test that shows MaxSafeDepDistBytes is incorrect. NFC.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 3 14:48:07 PDT 2023


fhahn added a comment.

Thanks for the updates! It looks like the check lines may need updating ,as the test appears to fail in precommit CI?



================
Comment at: llvm/test/Analysis/LoopAccessAnalysis/max_safe_dep_dist_non_unit_stride.ll:28
+entry:
+  %cmp18 = icmp sgt i32 %len, 0
+  %0 = zext i32 %len to i64
----------------
michaelmaitland wrote:
> fhahn wrote:
> > is this needed?
> What do you have in mind to guard entrance into loop when len <= 0?
I think the guard is not needed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154173/new/

https://reviews.llvm.org/D154173



More information about the llvm-commits mailing list