[PATCH] D153963: [InstCombine] Fold binop of select and cast of select condition

Mon Jul 3 13:23:57 PDT 2023

nikic added inline comments.

================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:913
+
+  if ((match(RHS, m_UIToFP(m_Value(A))) || match(RHS, m_SIToFP(m_Value(A)))) &&
+      A->getType()->getScalarSizeInBits() == 1) {
----------------
I don't think we should support uitofp/sitofp in this fold -- this seems way too contrived. It would be okay if this fell out of some generic handling, but not something we should spend lines of code on.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153963/new/

https://reviews.llvm.org/D153963