[PATCH] D139092: [LLD][ELF] Cortex-M Security Extensions (CMSE) Support

[Amilendra Kodithuwakku via Phabricator via llvm-commits]

amilendra added inline comments.


================
Comment at: lld/ELF/SyntheticSections.h:1151
+
+class ArmCmseSGVeneer {
+public:
----------------
peter.smith wrote:
> Can the definition be moved into ARM.cpp? In ArmCMSESGVeneerSection the type is only used by name so we should be able to forward declare it here?
I did try this, but it gave me an incomplete type error. It works for Thunk so can't see why it doesn't here. I'll give it another go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139092/new/

https://reviews.llvm.org/D139092